Update losses implementation #11667
Merged
Update losses implementation #11667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor rewording
Made explicit HTTPS call
Replaced deprecated contrib with tf.losses.sigmoid_cross_entropy()
Correcting losses function call
Replace deprecated contrib with tf.losses
|
Can one of the admins verify this patch? |
vrv
reviewed
Jul 24, 2017
| @@ -4,7 +4,7 @@ | |||
| # you may not use this file except in compliance with the License. | |||
| # You may obtain a copy of the License at | |||
| # | |||
| # http://www.apache.org/licenses/LICENSE-2.0 | |||
| # https://www.apache.org/licenses/LICENSE-2.0 | |||
There was a problem hiding this comment.
For better or worse, the original link is what is in the Apache license. can we keep it the way it is to keep the headers identical?
|
@tensorflow-jenkins test this please |
Minor explanation of abbreviate attribute
Keeping all the headers the same
|
@vrv could you test it now? |
|
re-testing. @tensorflow-jenkins test this please |
|
Can you remove the unrelated changes that aren't about losses? |
Revert unrelated changes
Revert unrelated changes
Revert unrelated changes
Reverting more changes
|
@vrv i have reverted unrelated changes. I will just submit a separate PR of them. |
|
Thanks -- some of those changes seemed unnecessary so I didn't want to delay this PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Various replacements of deprecated functions with equivalent tf.losses
-Minor HTTPS calls